Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(encode_logfmt): correctly handle values with equal signs #294

Merged
merged 4 commits into from
Jul 5, 2023
Merged

fix(encode_logfmt): correctly handle values with equal signs #294

merged 4 commits into from
Jul 5, 2023

Conversation

dsmith3197
Copy link
Contributor

@dsmith3197 dsmith3197 requested a review from fuchsnj July 5, 2023 15:10
fuchsnj
fuchsnj approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@fuchsnj fuchsnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget to add an entry to changelog.md

@dsmith3197 dsmith3197 merged commit b37bc02 into main Jul 5, 2023
@dsmith3197 dsmith3197 deleted the dougsmith/logfmt-encode-equals branch July 5, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuchsnj fuchsnj fuchsnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encode_logfmt mishandles "="
2 participants
@dsmith3197 @fuchsnj