Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): make deps optional #6404

Merged
merged 2 commits into from
Feb 9, 2021
Merged

chore(deps): make deps optional #6404

merged 2 commits into from
Feb 9, 2021

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Feb 9, 2021

When worked on #6202 I noted that some dependencies can be disabled by default. This PR makes them optional. Also, dependencies are sorted now.

New optional dependencies:

  • bloom
  • fakedata_generator
  • grok
  • lru
  • semver
  • syslog
  • syslog_loose
  • uuid

Removed dependencies (they moved to remap-functions):

  • hex
  • md-5
  • sha-1
  • sha2
  • sha3

@fanatid fanatid added the domain: deps Anything related to Vector's dependencies label Feb 9, 2021
@fanatid fanatid added this to the 2021-02-01 D-Fuel milestone Feb 9, 2021
@fanatid fanatid self-assigned this Feb 9, 2021
@fanatid fanatid requested review from a team, lukesteensen, leebenson and pablosichert and removed request for a team February 9, 2021 17:15
pablosichert
pablosichert approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@pablosichert pablosichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻👍🏻👍🏻 for the sorting, has also been bugging me for a while 😄

jszwedko
jszwedko approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work!

@fanatid fanatid force-pushed the make-deps-optional branch from 0bd1492 to b37583e Compare February 9, 2021 18:21
@fanatid
sort deps/features
16ed771 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid
make external libs optional
6ba9005 
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
@fanatid fanatid force-pushed the make-deps-optional branch from b37583e to 6ba9005 Compare February 9, 2021 18:36
lukesteensen
lukesteensen approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@lukesteensen lukesteensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@fanatid fanatid merged commit a67a5bc into master Feb 9, 2021
@fanatid fanatid deleted the make-deps-optional branch February 9, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@lukesteensen lukesteensen lukesteensen approved these changes

@pablosichert pablosichert pablosichert approved these changes

@leebenson leebenson Awaiting requested review from leebenson

Assignees

@fanatid fanatid

Labels
domain: deps Anything related to Vector's dependencies
Projects
None yet
Milestone
2021-02-01 D-Fuel
Development

Successfully merging this pull request may close these issues.
4 participants
@fanatid @jszwedko @lukesteensen @pablosichert