chore(deps): update #6217
Merged
chore(deps): update #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2021
|
Fix for |
|
Looks like |
binarylogic
requested review from
jszwedko
and removed request for
lukesteensen
|
I think Jesse disable benchmark fails, but maybe I'm wrong. Regressed benchmarks: |
|
cc @MOZGIII on the regression since you were working on performance in that crate. |
|
The results suggest that the system performance is unstable. The benches are written in such a way that they're supposed to highlight overhead from certain operations, and in this case the regression can be observed in the benches that are 100% unaffected by the metrics crate - I'd prefer to get a second opinion on this, but I think it's the system instability that caused this numbers. I'll double-check the source to reassure. |
This was referenced Jan 30, 2021
fanatid
requested review from
a team and
pablosichert
and removed request for
a team
|
Week update. |
|
I'm not sure if it is related to the I'm running this on of the benchmark runners to reduce noise. Simply running the master benchmarks twice, for example, does not show regressions as might be expected if they were noisy. I'll try to run the full suite. |
|
To answer the question about the CI run, we haven't yet enabled failing that workflow when regressions are detected. I wanted to collect some data about how often we see false positives with it now that it is mostly stable. |
|
Or rather, we have the results from the last CI run. The changed benchmarks: It seems like the bulk are in the metrics subsystem micro-benches. I think it is worth looking at them more closely; maybe starting with the changelog for the metrics crate. |
|
Can we remove the metrics upgrade and proceed with upgrading the rest of the dependencies? |
bruceg
reviewed
Feb 2, 2021
Cargo.toml
Outdated
| dashmap = "3" | ||
| dashmap = "4" |
There was a problem hiding this comment.
ISTR there was a regression issue with dashmap 4, though I don't recall the details. Perhaps relevant to the metrics performance regression?
There was a problem hiding this comment.
It is exactly my thinking as well - dashmap 4 has a different and slower implementation, and I suspect this to be the cause of the regression.
There was a problem hiding this comment.
Downgrade dashmap back to 3.
There was a problem hiding this comment.
@fanatid do you think this was the cause of the regression you noted here? If so, we might be able to upgrade the metrics dependency?
There was a problem hiding this comment.
No, it does not help. I downgraded metrics crates in addition and waiting benchmark for confirmation that everything is ok.
This was referenced Feb 8, 2021
fanatid
force-pushed
the
bump-deps-weekly
branch
from
801d39c to
950630f
Compare
|
Still regression for some metrics benchmarks: |
|
To clarify, removing the |
|
Yes, that's correct, I removed |
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
fanatid
force-pushed
the
bump-deps-weekly
branch
from
00caf59 to
06c8c8b
Compare
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
|
I pinned metrics crates, no regression now. CI job: https://github.com/timberio/vector/runs/1869218472?check_suite_focus=true Updated crates (in
|
Signed-off-by: Kirill Fomichev <fanatid@ya.ru>
jszwedko
added a commit
that referenced
this pull request
Mar 1, 2021
It was pinned in #6217 because it was believed it required Tokio 1.0 but I'm not actually seeing this. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metricscrates chore(deps): bump metrics-util from 0.4.0-alpha.10 to 0.4.0-alpha.11 #6206rust_decimalchore(deps): bump rust_decimal from 1.9.0 to 1.10.1 #6213cargo update --aggressiveI also pinned
async-graphql/async-graphql-warpbecause they addtokio:1.0(#5175).