Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vrl): add documentation for punycode encoding functions #19794

Merged
merged 15 commits into from
Feb 9, 2024

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Feb 5, 2024

@esensar esensar requested review from a team as code owners February 5, 2024 13:15
@bits-bot
Copy link

bits-bot commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Feb 5, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esensar ! I realized this one and #19795 won't pass until we update VRL. I'll approve for now and we can merge once VRL is updated.

@jszwedko jszwedko enabled auto-merge February 8, 2024 15:37
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 8, 2024
@jszwedko
Copy link
Member

jszwedko commented Feb 8, 2024

@esensar apologies, do you mind merging master into this and your other PR? I tried to but it doesn't look like I have access to push to this branch.

pront and others added 4 commits February 8, 2024 22:33
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
….0.2 (vectordotdev#19823)

chore(ci): Bump aws-actions/configure-aws-credentials

Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](aws-actions/configure-aws-credentials@v4.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the prost group with 1 update: [prost-reflect](https://github.com/andrewhickman/prost-reflect).


Updates `prost-reflect` from 0.12.0 to 0.13.0
- [Changelog](https://github.com/andrewhickman/prost-reflect/blob/main/CHANGELOG.md)
- [Commits](andrewhickman/prost-reflect@0.12.0...0.13.0)

---
updated-dependencies:
- dependency-name: prost-reflect
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prost
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
auto-merge was automatically disabled February 8, 2024 21:33

Head branch was pushed to by a user without write access

@esensar esensar requested a review from a team February 8, 2024 21:33
@jszwedko jszwedko enabled auto-merge February 8, 2024 21:39
auto-merge was automatically disabled February 9, 2024 08:39

Head branch was pushed to by a user without write access

@esensar
Copy link
Contributor Author

esensar commented Feb 9, 2024

I have just realized that I have messed up the history of this branch yesterday. Do you want me to force push, or make another PR, or is this fine? I guess you are squashing, so it is probably okay to leave it as is, but let me know if you need me to make some changes.

@jszwedko
Copy link
Member

jszwedko commented Feb 9, 2024

@esensar no worries! We do squash PRs when merging so the branch history doesn't matter too much.

@jszwedko jszwedko enabled auto-merge February 9, 2024 15:36
auto-merge was automatically disabled February 9, 2024 15:52

Head branch was pushed to by a user without write access

@jszwedko jszwedko enabled auto-merge February 9, 2024 17:34
@jszwedko jszwedko added this pull request to the merge queue Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Regression Detector Results

Run ID: e78b92e1-368b-4273-9a39-3aaee4f2161e
Baseline: 94fceb4
Comparison: 5910f87
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
http_text_to_http_json ingress throughput +1.66 [+1.53, +1.80]
otlp_http_to_blackhole ingress throughput +1.56 [+1.41, +1.70]
socket_to_socket_blackhole ingress throughput +1.12 [+1.04, +1.20]
syslog_loki ingress throughput +0.85 [+0.80, +0.91]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.64 [+0.57, +0.71]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.55 [+0.42, +0.69]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.51 [+0.42, +0.60]
syslog_splunk_hec_logs ingress throughput +0.36 [+0.29, +0.43]
datadog_agent_remap_blackhole ingress throughput +0.30 [+0.21, +0.39]
splunk_hec_route_s3 ingress throughput +0.26 [-0.23, +0.75]
file_to_blackhole egress throughput +0.14 [-2.40, +2.68]
http_to_http_noack ingress throughput +0.08 [-0.03, +0.18]
http_elasticsearch ingress throughput +0.07 [+0.00, +0.14]
http_to_s3 ingress throughput +0.05 [-0.24, +0.33]
http_to_http_json ingress throughput +0.03 [-0.05, +0.10]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.16, +0.16]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.07]
enterprise_http_to_http ingress throughput -0.07 [-0.15, +0.01]
datadog_agent_remap_datadog_logs ingress throughput -0.09 [-0.16, -0.01]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.50 [-0.61, -0.38]
http_to_http_acks ingress throughput -0.52 [-1.82, +0.79]
otlp_grpc_to_blackhole ingress throughput -0.56 [-0.65, -0.47]
syslog_humio_logs ingress throughput -1.17 [-1.28, -1.06]
syslog_log2metric_humio_metrics ingress throughput -1.38 [-1.50, -1.26]
fluent_elasticsearch ingress throughput -1.49 [-1.96, -1.02]
datadog_agent_remap_blackhole_acks ingress throughput -2.18 [-2.28, -2.09]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

github-actions bot commented Feb 9, 2024

Regression Detector Results

Run ID: 53b59a4e-f4b4-4ad9-90d6-84a26989d4cd
Baseline: de628d8
Comparison: 1e83c95
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_regex_logs2metric_ddmetrics ingress throughput +1.30 [+1.21, +1.39]
syslog_humio_logs ingress throughput +1.05 [+0.94, +1.15]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.98 [+0.91, +1.05]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.57 [+0.43, +0.70]
fluent_elasticsearch ingress throughput +0.53 [+0.06, +1.01]
http_to_http_acks ingress throughput +0.50 [-0.81, +1.81]
syslog_loki ingress throughput +0.43 [+0.37, +0.50]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.41 [+0.30, +0.52]
datadog_agent_remap_datadog_logs ingress throughput +0.26 [+0.19, +0.33]
http_to_s3 ingress throughput +0.06 [-0.21, +0.34]
http_to_http_noack ingress throughput +0.05 [-0.05, +0.15]
http_text_to_http_json ingress throughput +0.03 [-0.09, +0.15]
http_to_http_json ingress throughput +0.01 [-0.06, +0.09]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.16, +0.16]
datadog_agent_remap_blackhole ingress throughput -0.03 [-0.13, +0.07]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.06 [-0.17, +0.04]
socket_to_socket_blackhole ingress throughput -0.07 [-0.14, -0.00]
otlp_grpc_to_blackhole ingress throughput -0.09 [-0.18, -0.00]
enterprise_http_to_http ingress throughput -0.10 [-0.17, -0.03]
syslog_splunk_hec_logs ingress throughput -0.11 [-0.19, -0.04]
otlp_http_to_blackhole ingress throughput -0.16 [-0.30, -0.01]
splunk_hec_route_s3 ingress throughput -0.29 [-0.78, +0.20]
http_elasticsearch ingress throughput -0.31 [-0.37, -0.24]
file_to_blackhole egress throughput -0.68 [-3.12, +1.77]
syslog_log2metric_humio_metrics ingress throughput -0.83 [-0.92, -0.74]
datadog_agent_remap_blackhole_acks ingress throughput -1.01 [-1.13, -0.90]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into vectordotdev:master with commit 0851fca Feb 9, 2024
49 checks passed
@esensar esensar deleted the docs/punycode_encoding branch February 9, 2024 21:55
AndrooTheChen pushed a commit to discord/vector that referenced this pull request Sep 23, 2024
…otdev#19794)

* docs(vrl): add documentation for punycode encoding functions

Related: vectordotdev/vrl#672

* Allow IDN and punycode in spellchecker

* Change IDN allow entry into lowercase

* chore: expose component test utils (vectordotdev#19826)

* chore(deps): Bump VRL to 0.11.0 (vectordotdev#19827)

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

* chore(ci): Bump aws-actions/configure-aws-credentials from 4.0.1 to 4.0.2 (vectordotdev#19823)

chore(ci): Bump aws-actions/configure-aws-credentials

Bumps [aws-actions/configure-aws-credentials](https://github.com/aws-actions/configure-aws-credentials) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/aws-actions/configure-aws-credentials/releases)
- [Changelog](https://github.com/aws-actions/configure-aws-credentials/blob/main/CHANGELOG.md)
- [Commits](aws-actions/configure-aws-credentials@v4.0.1...v4.0.2)

---
updated-dependencies:
- dependency-name: aws-actions/configure-aws-credentials
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): Bump the prost group with 1 update (vectordotdev#19830)

Bumps the prost group with 1 update: [prost-reflect](https://github.com/andrewhickman/prost-reflect).


Updates `prost-reflect` from 0.12.0 to 0.13.0
- [Changelog](https://github.com/andrewhickman/prost-reflect/blob/main/CHANGELOG.md)
- [Commits](andrewhickman/prost-reflect@0.12.0...0.13.0)

---
updated-dependencies:
- dependency-name: prost-reflect
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prost
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update punycode encoding to be fallible in docs

* Add failure reasons for punycode encoding

* Fix typo in decode_punycode docs

* Simplify error descriptions for punycode_encoding

* Fix formatting of punycode_encoding cue files

---------

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants