docs(aws_sqs source): remove credentials_file from docs #11272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
|
✔️ Deploy Preview for vector-project ready! 🔨 Explore the source changes: a7c8144 🔍 Inspect the deploy log: https://app.netlify.com/sites/vector-project/deploys/62067b3808c0650007a41064 😎 Browse the preview: https://deploy-preview-11272--vector-project.netlify.app |
github-actions
bot
added
the
domain: external docs
jszwedko
reviewed
Feb 9, 2022
| package metadata | ||
|
|
||
| components: _aws_new_sdk: { | ||
| configuration: { |
There was a problem hiding this comment.
It seems like only the auth configuration differs from components: _aws_sdk. Could we maybe inherit the other config and just define auth here?
Like:
components: _aws_new_sdk: {
configuration: {
auth: ...
endpoint: components._aws_sdk.configuration.endpoint,
}
etc.
Maybe we could just error on startup if the option is used rather than worry about splitting up all AWS authentication configuration structs. |
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
github-actions
bot
added
the
domain: sources
Have done this. |
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Soak Test ResultsBaseline: 6d8a6a7 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes with confidence ≥ 90.00%: Fine details of change detection per experiment.
Fine details of each soak run.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11082
This removes the
credentials_filesetting from the docs for the aws_sqs source.Since all the aws sources share a cue file for the aws settings, I have creating a new one (aws_new_sdk.cue) with the
credentials_filesetting removed that this one uses instead.Signed-off-by: Stephen Wakely fungus.humungus@gmail.com