-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 943 certificate.ts verify explicits encoding chain from JSON/str… #962
Conversation
…ing to binary hash
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat are high entropy strings?Contains high entropy strings. This could be a sign of encrypted data, leaked secrets or obfuscated code. Please inspect these strings to check if these strings are benign. Maintainers should clarify the purpose and existence of high entropy strings if there is a legitimate purpose. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
@SocketSecurity ignore npm/jiti@1.21.0 npm/prettier@3.2.5 |
Description
The code at
packages/core/src/certificate/certificate.ts
match
method to verify if any binary encoded certificate matches with signer's address and signature,verify
method to usematch
, this method explicits the transformation from certificate trough its JSON/string to its binary encoding used to compute the hash to match signer's address with signature.representation
Fixes # 943
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
yarn test:solo
Test Configuration:
Checklist: