-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parses new emojis.json and fix encoding problems #152
base: master
Are you sure you want to change the base?
Conversation
I really appreciate the effort! Thanks for working on this. I cannot review in github (the diff is too big and won't load) so I'll try to review later but it looks like it's going to take a looooong time. I am worried about:
This breaks retrocompatibility. Was it really necessary? |
Hey, If it does, I'll compare and add old aliases. Will update in the next couple of days. |
@Jbwzx Hi. It also seems like you have lost |
@alexgasparyan just double checked, you're right. will fix alongside aliases. Thanks |
any updates on this one? |
At the very least we can download the json for now and load it manually |
Would be nice to get some updates on this, almost exactly a year later |
@gdude2002 Funny enough, I've actually put it in my todo list last weekend. I'll try to sort it out in the following fortnight |
@gdude2002 ready.
and of course as mentioned year ago encoding issue fixed. |
Hi Our team would like to use this latest commits. Is there an ETA where we could get these changes merged? Thanks |
Hey. Not sure re merge, but what we did with one of our commercial project is simply added lib as a submodule replacing reparsed lib file. Hope this helps. |
This pr:
old emojis.json
new emojis.json
Notes: