Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case for internal/errorgroup #494

Merged
merged 12 commits into from
Jun 22, 2020
Merged

Added test case for internal/errorgroup #494

merged 12 commits into from
Jun 22, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jun 18, 2020 •
edited
Loading

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added a test case for internal/errorgroup.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@hlts2 hlts2 requested a review from kevindiu June 18, 2020 08:19
@hlts2 hlts2 self-assigned this Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #494 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #494      +/-   ##
=========================================
+ Coverage    7.97%   8.32%   +0.34%     
=========================================
  Files         401     401              
  Lines       20705   20705              
=========================================
+ Hits         1651    1723      +72     
+ Misses      18812   18739      -73     
- Partials      242     243       +1
Impacted Files Coverage Δ
internal/errgroup/group.go 94.73% <0.00%> (+94.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad8de1...3662e95. Read the comment docs.

@hlts2
Copy link
Collaborator Author

hlts2 commented Jun 19, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/errorgroup

@vdaas-ci vdaas-ci force-pushed the test/internal/errorgroup branch from db9325d to cc8a38c Compare June 19, 2020 01:35
kevindiu
kevindiu reviewed Jun 22, 2020
View reviewed changes
internal/errgroup/group_test.go Outdated Show resolved Hide resolved
internal/errgroup/group_test.go Outdated Show resolved Hide resolved
@pull-assistant
Copy link

pull-assistant bot commented Jun 22, 2020 •
edited
Loading

Score: 0.83

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

     feat: test case

     fix: refactor

     fix: refactor

     fix: goleak bug

     Update internal/errgroup/group_test.go

fix: apply suggestion

go.sum 50% changes removed in fix: revert go.sum

     fix: revert go.sum

     fix: revert go.sum

fix: apply suggestion

go.sum 50% changes removed in fix: revert go.sum

     fix: revert go.sum

     fix: revert go.sum

     fix: apply suggestion

Powered by Pull Assistant. Last update 3cd90b8 ... 3662e95. Read the comment docs.

@hlts2
Copy link
Collaborator Author

hlts2 commented Jun 22, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/errorgroup

hlts2 and others added 5 commits June 22, 2020 04:23
@hlts2 @actions-user
feat: test case
3cd90b8 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: refactor
3caf60c 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: refactor
bdf32df 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @actions-user
fix: goleak bug
a5f93b5 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 @kevindiu @actions-user
Update internal/errgroup/group_test.go
693a1bf 
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
@vdaas-ci vdaas-ci force-pushed the test/internal/errorgroup branch from 566784d to 693a1bf Compare June 22, 2020 04:23
hlts2 added 6 commits June 22, 2020 13:29
@hlts2
fix: apply suggestion
52afd43 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: revert go.sum
9b32cdc 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: revert go.sum
3713b75 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: apply suggestion
73e4d22 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: revert go.sum
2e5d15d 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
fix: revert go.sum
ee5d1db 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
kevindiu reviewed Jun 22, 2020
View reviewed changes
internal/errgroup/group_test.go Outdated Show resolved Hide resolved
internal/errgroup/group_test.go Outdated Show resolved Hide resolved
internal/errgroup/group_test.go Outdated Show resolved Hide resolved
@hlts2
fix: apply suggestion
3662e95 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kevindiu
kevindiu approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/errorgroup

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit e8ce139 into master Jun 22, 2020
@vankichi vankichi deleted the test/internal/errorgroup branch June 22, 2020 06:55
@vdaas-ci vdaas-ci mentioned this pull request Jun 25, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@vankichi vankichi vankichi approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees

@hlts2 hlts2

Labels
area/internal priority/low size/XL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hlts2 @vdaas-ci @vankichi @kevindiu @kpango