Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL workflow instead of LGTM.com #486

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 18, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

  • Add CodeQL workflow from GitHub.com
  • After this PR is merged, please remove LGTM.com integration.
    • in the LGTM analysis, libhdf5 cannot be installed by configuring lgtm.yml.
    • it is easier to configure the runner environment by using CodeQL workflow (GitHub Actions).

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the ci/semmle-lgtm/add-lgtm-yaml branch from 13d2af9 to 2113375 Compare June 18, 2020 05:37
@kpango
Copy link
Collaborator

kpango commented Jun 18, 2020

what a nice integration idea

@rinx rinx marked this pull request as ready for review June 18, 2020 06:30
@rinx rinx requested a review from kpango June 18, 2020 06:37
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 1038c46 into master Jun 18, 2020
@kpango kpango deleted the ci/semmle-lgtm/add-lgtm-yaml branch June 18, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants