-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithOperation func to loadtest usecase #454
Conversation
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Best reviewed: commit by commit
Optimal code review plan
|
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=========================================
+ Coverage 7.82% 7.84% +0.02%
=========================================
Files 389 388 -1
Lines 20003 19945 -58
=========================================
Hits 1565 1565
+ Misses 18214 18156 -58
Partials 224 224 Continue to review full report at Codecov.
|
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com
Description:
I found that the
method
variable is not passed to loadtest service. without it, the loadtest app does not work correctly.fixed it.
Related Issue:
nothing.
How Has This Been Tested?:
nothing.
Environment:
Types of changes:
Changes to Core Features:
Checklist: