Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation logic for manager indexer #2797

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix validation logic for manager indexer #2797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116bd00
fix validation logic for manager indexer
aknishid Jan 8, 2025
ac793a5
Change validation to include zero.
aknishid Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/manager/index/service/indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
}
i.indexing.Store(false)
i.saving.Store(false)
if i.indexDuration+i.indexDurationLimit+i.saveIndexDurationLimit <= 0 {
if i.indexDuration <= 0 && i.indexDurationLimit <= 0 && i.saveIndexDurationLimit <= 0 {

Check warning on line 79 in pkg/manager/index/service/indexer.go

View check run for this annotation

Codecov / codecov/patch

pkg/manager/index/service/indexer.go#L79 

Added line #L79 was not covered by tests
return nil, errors.ErrInvalidConfig
}
return i, nil
Expand Down
Loading