Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix vald-helm-operator build error #2610

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Bugfix vald-helm-operator build error #2610

merged 1 commit into from
Sep 11, 2024

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Sep 11, 2024 •
edited by coderabbitai bot
Loading

Description

Changed the command to build helm-operator to be unified with the naming of other commands.
Here is an example of a benchmark operator. I have made changes to follow this format.

.PHONY: docker/name/benchmark-operator
docker/name/benchmark-operator:
...

I have made changes to follow this format.

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.0
  • Rust Version: v1.80.0
  • Docker Version: v27.1.1
  • Kubernetes Version: v1.30.3
  • Helm Version: v3.15.3
  • NGT Version: v2.2.4
  • Faiss Version: v1.8.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Chores
    • Renamed build and naming targets for the Helm operator to improve clarity and organization in the build process.

@hlts2
fix: make command name
b060755 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024 •
edited
Loading

Walkthrough

Walkthrough

The pull request modifies the Makefile.d/docker.mk by renaming targets associated with the Helm operator. Specifically, the target docker/build/operator/helm is renamed to docker/build/helm-operator, and the phony target docker/name/operator/helm is renamed to docker/name/helm-operator. These changes are made to improve clarity in the naming conventions while ensuring that the build process remains functional.

Changes

Files Change Summary
Makefile.d/docker.mk Renamed .PHONY: docker/name/operator/helm to .PHONY: docker/name/helm-operator
Renamed docker/build/operator/helm: to docker/build/helm-operator:
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c3c5765 and b060755.

Files selected for processing (1)
  • Makefile.d/docker.mk (2 hunks)
Files skipped from review due to trivial changes (1)
  • Makefile.d/docker.mk

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 self-assigned this Sep 11, 2024
@hlts2 hlts2 requested review from kpango and vankichi September 11, 2024 05:25
@kpango kpango merged commit 5e385d0 into main Sep 11, 2024
172 of 173 checks passed
@kpango kpango deleted the fix/helm/operator branch September 11, 2024 07:23
vdaas-ci pushed a commit that referenced this pull request Sep 11, 2024
@hlts2 @vdaas-ci
fix: make command name (#2610)
592461a 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@coderabbitai coderabbitai bot mentioned this pull request Sep 11, 2024
Merged
2 tasks
vankichi pushed a commit that referenced this pull request Sep 12, 2024
@vdaas-ci @hlts2
Fix: make command name (#2610) (#2612)
9994e2c 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Closed
@kpango kpango mentioned this pull request Oct 11, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 25, 2024
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2024
Merged
2 tasks
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
@hlts2 @takuyaymd
fix: make command name (vdaas#2610)
a653ea5 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
@hlts2 @takuyaymd
fix: make command name (vdaas#2610)
a7b808c 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@vankichi vankichi vankichi approved these changes

@kpango kpango kpango approved these changes

Assignees

@hlts2 hlts2

Labels
actions/backport/release/v1.7 area/makefile priority/low size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @kpango @vankichi