Start k3d in ci-container and execute e2e test to k8s cluster #2553
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
WalkthroughWalkthroughThe recent updates to the GitHub Actions workflows introduce a new job, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
type/ci
size/S
type/feature
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying vald with
|
| Latest commit: |
4ada8ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0821604e.vald.pages.dev |
| Branch Preview URL: | https://feat-execute-e2e-in-dood.vald.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .github/actions/setup-k3d/action.yaml (1 hunks)
- .github/workflows/e2e-chaos.yaml (4 hunks)
- .github/workflows/e2e-code-bench-agent.yaml (2 hunks)
- .github/workflows/e2e-max-dim.yml (1 hunks)
- .github/workflows/e2e-profiling.yml (1 hunks)
- .github/workflows/e2e.yml (9 hunks)
Additional comments not posted (17)
.github/actions/setup-k3d/action.yaml (1)
79-79: LGTM! Ensure the new API port configuration is correctly utilized.The addition of
--api-port host.docker.internal:6550looks good. Verify that this configuration is correctly utilized in the codebase..github/workflows/e2e-code-bench-agent.yaml (2)
61-61: LGTM! The container options enhance capabilities.The addition of
--privileged --add-host host.docker.internal:host-gatewayenhances the container's capabilities. Ensure these options are necessary and used correctly.
89-89: LGTM! The container options enhance capabilities.The addition of
--privileged --add-host host.docker.internal:host-gatewayenhances the container's capabilities. Ensure these options are necessary and used correctly..github/workflows/e2e-max-dim.yml (3)
34-36: LGTM! The new job enhances functionality.The addition of the
detect-ci-containerjob enhances the workflow's functionality by integrating a container detection step.
39-39: LGTM! The job dependency ensures proper sequencing.Updating the
e2e-max-dimension-insertjob to depend ondetect-ci-containerensures proper sequencing and enhances the workflow.
42-44: LGTM! The container configuration enhances the job's capabilities.The container configuration for the
e2e-max-dimension-insertjob, including the image and options, enhances the job's capabilities..github/workflows/e2e-profiling.yml (3)
35-37: LGTM! The new jobdetect-ci-containeris well-defined.The conditional statement ensures that the job runs only under specific conditions, which is a good practice for controlling job execution.
40-40: Dependency update approved.The
e2e-profilingjob now depends ondetect-ci-container, which aligns with the new job addition and ensures proper control flow.
43-45: Container specification approved.The
containersection ensures that thee2e-profilingjob runs in a specific container environment, enhancing flexibility and consistency..github/workflows/e2e-chaos.yaml (4)
25-26: Trigger condition update approved.The removal of the
typesspecification under thepull_requesttrigger broadens the conditions under which the workflow is triggered, enhancing responsiveness.
37-39: LGTM! The new jobdetect-ci-containeris well-defined.The conditional statement ensures that the job runs only under specific conditions, which is a good practice for controlling job execution.
42-42: Dependency update approved.The jobs
agent-failure,random-pod-failure,agent-network-partition, andclusterwide-network-bandwidthnow depend ondetect-ci-container, which aligns with the new job addition and ensures proper control flow.Also applies to: 83-83, 124-124, 165-165
45-47: Container specification approved.The
containersection ensures that the jobs run in a specific container environment, enhancing flexibility and consistency.Also applies to: 86-88, 127-129, 168-170
.github/workflows/e2e.yml (4)
25-26: Trigger condition update approved.The removal of the
typesspecification under thepull_requesttrigger broadens the conditions under which the workflow is triggered, enhancing responsiveness.
36-38: LGTM! The new jobdetect-ci-containeris well-defined.The conditional statement ensures that the job runs only under specific conditions, which is a good practice for controlling job execution.
41-41: Dependency update approved.The jobs now depend on
detect-ci-container, which aligns with the new job addition and ensures proper control flow.Also applies to: 82-82, 145-145, 190-190, 231-231, 268-268, 302-302, 353-353
44-46: Container specification approved.The
containersection ensures that the jobs run in a specific container environment, enhancing flexibility and consistency.Also applies to: 85-87, 148-150, 193-195, 234-236, 271-273, 305-307, 356-358
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/e2e-chaos.yaml (4 hunks)
- .github/workflows/e2e-max-dim.yml (1 hunks)
- .github/workflows/e2e-profiling.yml (1 hunks)
- .github/workflows/e2e.yml (8 hunks)
Files skipped from review as they are similar to previous changes (2)
- .github/workflows/e2e-chaos.yaml
- .github/workflows/e2e-profiling.yml
Additional comments not posted (9)
.github/workflows/e2e-max-dim.yml (1)
39-44: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job..github/workflows/e2e.yml (8)
40-45: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
189-194: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
144-149: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
230-235: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
301-306: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
81-86: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
352-357: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
267-272: Verify the necessity of the--privilegedoption.The
--privilegedoption grants extended privileges to the container, which can pose security risks. Ensure that this option is necessary for the job.
| detect-ci-container: | ||
| # if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy' | ||
| uses: ./.github/workflows/_detect-ci-container.yml |
There was a problem hiding this comment.
Add the if condition for better control.
The if condition is commented out. It should be uncommented to ensure the job runs only under the specified conditions.
- # if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy'
+ if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy'Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| detect-ci-container: | |
| # if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy' | |
| uses: ./.github/workflows/_detect-ci-container.yml | |
| detect-ci-container: | |
| if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy' | |
| uses: ./.github/workflows/_detect-ci-container.yml |
| detect-ci-container: | ||
| # if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy' | ||
| uses: ./.github/workflows/_detect-ci-container.yml |
There was a problem hiding this comment.
Add the if condition for better control.
The if condition is commented out. It should be uncommented to ensure the job runs only under the specified conditions.
- # if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy'
+ if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy'Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| detect-ci-container: | |
| # if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy' | |
| uses: ./.github/workflows/_detect-ci-container.yml | |
| detect-ci-container: | |
| if: startsWith( github.ref, 'refs/tags/') || github.event.action == 'labeled' && github.event.label.name == 'actions/e2e-deploy' | |
| uses: ./.github/workflows/_detect-ci-container.yml |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/actions/setup-e2e/action.yaml (1 hunks)
- .github/workflows/e2e-profiling.yml (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/actions/setup-e2e/action.yaml
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/e2e-profiling.yml
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/e2e/kubernetes/portforward/portforward.go (1 hunks)
Additional comments not posted (1)
tests/e2e/kubernetes/portforward/portforward.go (1)
71-71: LGTM! Improved URL handling.The change from
strings.TrimLeftto two calls tostrings.TrimPrefixensures that both "http://" and "https://" prefixes are correctly handled, improving robustness.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/e2e-chaos.yaml (8 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/e2e-chaos.yaml
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/helm/values/values-chaos.yaml (1 hunks)
- .github/workflows/e2e.yml (9 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/e2e.yml
Additional comments not posted (1)
.github/helm/values/values-chaos.yaml (1)
38-38: Change approved: Update host tohost.docker.internal.The change from
"localhost"to"host.docker.internal"is appropriate for routing traffic correctly in containerized environments.
Description
As titled
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
New Features
detect-ci-containerwhich enhances the CI workflow by dynamically determining the appropriate container image based on specific conditions.detect-ci-container, improving flexibility and responsiveness in the workflow.Bug Fixes
pull_requestevent trigger types, streamlining how workflows are activated.Improvements