[DO NOT MERGE] Vefify for #2549 #2551
Conversation
Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
Important Review skippedIgnore keyword(s) in the title. Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying vald with
|
| Latest commit: |
5ea7269
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05d80d24.vald.pages.dev |
| Branch Preview URL: | https://fix-dependency-update-go-mod.vald.pages.dev |
kpango
force-pushed
the
dependency/update/go-modules
branch
from
120d86f to
ff4b6e3
Compare
|
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
hadolint
Last USER should not be root
vald/dockers/manager/index/Dockerfile
Line 27 in 93fa7ce
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
vald/dockers/manager/index/Dockerfile
Line 52 in 93fa7ce
Last USER should not be root
vald/dockers/operator/helm/Dockerfile
Line 30 in 93fa7ce
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
vald/dockers/operator/helm/Dockerfile
Line 55 in 93fa7ce
Last USER should not be root
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
Last USER should not be root
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
Last USER should not be root
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
| FROM ghcr.io/vdaas/vald/vald-buildbase:nightly AS builder | ||
| ARG MAINTAINER="vdaas.org vald team <vald@vdaas.org>" | ||
| LABEL maintainer="${MAINTAINER}" | ||
|
|
||
| # skipcq: DOK-DL3002 | ||
| USER root:root |
| # skipcq: DOK-DL3008 | ||
| RUN apt-get clean \ | ||
| #skipcq: DOK-W1001, DOK-SC2046, DOK-SC2086, DOK-DL3008 | ||
| RUN rm -f /etc/apt/apt.conf.d/docker-clean \ |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
| } else { | ||
| user := data.BuildUser | ||
| if strings.Contains(user, ":") { | ||
| user = strings.SplitN(user, ":", 2)[0] |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Magic number: 2, in detected (gomnd)
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 18.43% 17.57% -0.87%
==========================================
Files 566 566
Lines 66342 68927 +2585
==========================================
- Hits 12232 12113 -119
- Misses 53320 55994 +2674
- Partials 790 820 +30 ☔ View full report in Codecov by Sentry. |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
This reverts commit 59cee1d.
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Description
Related Issue
Versions
Checklist
Special notes for your reviewer