Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert docker-image.yaml change #2336

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Revert docker-image.yaml change #2336

merged 1 commit into from
Feb 8, 2024

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Feb 8, 2024 •
edited
Loading

Description

SSIA

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

@vankichi vankichi requested review from kpango and hlts2 February 8, 2024 08:09
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi requested review from kmrmt and ykadowak February 8, 2024 08:09
@vankichi
💚 Revert docker-image.yaml change
c4f763b 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the revert/ci/docker-image branch from 03c0a83 to c4f763b Compare February 8, 2024 08:12
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 8, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c4f763b
Status: ✅  Deploy successful!
Preview URL: https://4413a0b9.vald.pages.dev
Branch Preview URL: https://revert-ci-docker-image.vald.pages.dev

View logs

hlts2
hlts2 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@vankichi vankichi merged commit e96ffd8 into main Feb 8, 2024
117 of 118 checks passed
@vankichi vankichi deleted the revert/ci/docker-image branch February 8, 2024 08:17
vdaas-ci pushed a commit that referenced this pull request Feb 8, 2024
@vankichi @vdaas-ci
💚 Revert docker-image.yaml change (#2336)
a7f8e4f 
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi added a commit that referenced this pull request Feb 8, 2024
@vdaas-ci @vankichi
💚 Revert docker-image.yaml change (#2336) (#2337)
4b9364a 
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
This was referenced Feb 15, 2024
Merged
Merged
This was referenced Mar 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@kpango kpango kpango approved these changes

@kmrmt kmrmt Awaiting requested review from kmrmt

@ykadowak ykadowak Awaiting requested review from ykadowak

Assignees
No one assigned
Labels
actions/backport/release/v1.7 priority/low size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kpango @hlts2