Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golangci-lint config and apply tagalign #2326

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Fix golangci-lint config and apply tagalign #2326

merged 6 commits into from
Feb 13, 2024

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Feb 7, 2024

Description:

  • Fixed .golangci-lint.yaml for updated style.
  • Apply tagalign to fix all the warnings

Related Issue:

Versions:

  • Go Version: 1.21.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@ykadowak
fix golangcilint config for updated version

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a44516d
@ykadowak
Apply tagalign

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
22eea3c
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 7, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 7, 2024

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (141515a) 30.29% compared to head (db14830) 18.70%.
Report is 7 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2326       +/-   ##
===========================================
- Coverage   30.29%   18.70%   -11.59%     
===========================================
  Files         393      548      +155     
  Lines       40954    73641    +32687     
===========================================
+ Hits        12407    13775     +1368     
- Misses      27882    59133    +31251     
- Partials      665      733       +68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykadowak
Merge branch 'main' into feature/lint/update2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a12a78e
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 8, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: db14830
Status: ✅  Deploy successful!
Preview URL: https://28074f27.vald.pages.dev
Branch Preview URL: https://feature-lint-update2.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2024

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@ykadowak ykadowak marked this pull request as ready for review February 13, 2024 05:05
hlts2
hlts2 previously approved these changes Feb 13, 2024
View reviewed changes
@ykadowak ykadowak requested a review from datelier February 13, 2024 05:07
ykadowak and others added 2 commits February 13, 2024 05:29
@ykadowak
fix indent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
940e45a
@deepsource-autofix
style: format code with Gofumpt and Prettier
0b7df25 
This commit fixes the style issues introduced in 940e45a according to the output
from Gofumpt and Prettier.

Details: #2326
deepsource-autofix bot added a commit that referenced this pull request Feb 13, 2024
@deepsource-autofix
style: format code with Gofumpt and Prettier
d887dad 
This commit fixes the style issues introduced in 4ceb9a2 according to the output
from Gofumpt and Prettier.

Details: #2326
@ykadowak ykadowak force-pushed the feature/lint/update2 branch from d887dad to db14830 Compare February 13, 2024 05:46
@ykadowak ykadowak requested a review from hlts2 February 13, 2024 05:53
hlts2
hlts2 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykadowak ykadowak merged commit b74f2a4 into main Feb 13, 2024
118 of 120 checks passed
@ykadowak ykadowak deleted the feature/lint/update2 branch February 13, 2024 06:08
This was referenced Feb 15, 2024
Merged
Merged
This was referenced Mar 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot]

@hlts2 hlts2

@datelier datelier

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling area/internal area/tools/cli/loadtest priority/medium size/L type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @hlts2 @datelier