Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format yaml using google/yamlfmt & update go version and dependencies #2322

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Format yaml using google/yamlfmt & update go version and dependencies #2322

merged 3 commits into from
Feb 8, 2024

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Feb 7, 2024 •
edited
Loading

Description:

SSIA

Wait for Go1.22 docker release.

Related Issue:

Versions:

  • Go Version: 1.21.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 7, 2024

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the dependencies/update-go-deps branch from b401e10 to 9998388 Compare February 7, 2024 00:21
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 7, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 925a42c
Status: ✅  Deploy successful!
Preview URL: https://8d77880c.vald.pages.dev
Branch Preview URL: https://dependencies-update-go-deps.vald.pages.dev

View logs

@kpango kpango changed the title format yaml using google/yamlfmt & update go version and dependencies [WIP] format yaml using google/yamlfmt & update go version and dependencies Feb 7, 2024
@kpango kpango force-pushed the dependencies/update-go-deps branch from 9998388 to b1f9ca8 Compare February 7, 2024 00:29
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (141515a) 30.29% compared to head (925a42c) 18.69%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2322       +/-   ##
===========================================
- Coverage   30.29%   18.69%   -11.60%     
===========================================
  Files         393      548      +155     
  Lines       40954    73639    +32685     
===========================================
+ Hits        12407    13767     +1360     
- Misses      27882    59137    +31255     
- Partials      665      735       +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpango kpango force-pushed the dependencies/update-go-deps branch from b1f9ca8 to a76b1a3 Compare February 7, 2024 01:20
@kpango kpango force-pushed the dependencies/update-go-deps branch 3 times, most recently from bf16e1c to 8d5f259 Compare February 7, 2024 02:57
@kpango kpango force-pushed the dependencies/update-go-deps branch 4 times, most recently from 874b7e6 to 70c4bcc Compare February 7, 2024 03:10
deepsource-autofix bot added a commit that referenced this pull request Feb 7, 2024
@deepsource-autofix
style: format code with Gofumpt and Prettier
299dc6e 
This commit fixes the style issues introduced in 70c4bcc according to the output
from Gofumpt and Prettier.

Details: #2322
kpango pushed a commit that referenced this pull request Feb 7, 2024
@deepsource-autofix @kpango
style: format code with Gofumpt and Prettier
db5a5ad 
This commit fixes the style issues introduced in 70c4bcc according to the output
from Gofumpt and Prettier.

Details: #2322
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the dependencies/update-go-deps branch from c95447f to 33afa24 Compare February 8, 2024 01:35
@vankichi
🐛 Fix infinite yaml format (#2330)
5492f9d 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@kpango kpango changed the title [WIP] format yaml using google/yamlfmt & update go version and dependencies Format yaml using google/yamlfmt & update go version and dependencies Feb 8, 2024
@kpango kpango requested review from a team, hlts2 and ykadowak and removed request for a team February 8, 2024 02:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/dependencies%2Fupdate-go-deps/b526893057452e04977142508fbedf203ab1b7f3

ykadowak
ykadowak previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ykadowak ykadowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if e2e passes

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2024

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@hlts2
fix: add dictionaly to detect target image tag (#2331)
925a42c 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@kpango kpango requested a review from ykadowak February 8, 2024 04:59
hlts2
hlts2 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit 1639e92 into main Feb 8, 2024
203 of 205 checks passed
@vankichi vankichi deleted the dependencies/update-go-deps branch February 8, 2024 05:20
This was referenced Feb 15, 2024
Merged
Merged
This was referenced Mar 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot]

@vankichi vankichi

@hlts2 hlts2

@ykadowak ykadowak

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/agent/core/faiss area/agent/core/ngt area/helm area/index/job/correction area/index/job/creation area/index/job/readreplica area/index/job/save area/internal area/makefile area/tools/cli/loadtest priority/low size/XXL type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpango @vdaas-ci @vankichi @hlts2 @ykadowak