bugfix grpc ip direct connection status check #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
size/S
type/bug
kpango
force-pushed
the
bugfix/internal-grpc/ip-connection-idle-removal-problem
branch
from
43eb9f5 to
a596c5f
Compare
Deploying with
|
| Latest commit: |
29b6ff2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cba62ec5.vald.pages.dev |
| Branch Preview URL: | https://bugfix-internal-grpc-ip-conn.vald.pages.dev |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
+ Coverage 30.30% 30.31% +0.01%
==========================================
Files 391 391
Lines 40945 40953 +8
==========================================
+ Hits 12407 12415 +8
- Misses 27875 27876 +1
+ Partials 663 662 -1 ☔ View full report in Codecov by Sentry. |
hlts2
reviewed
Feb 1, 2024
vankichi
previously approved these changes
Feb 1, 2024
hlts2
reviewed
Feb 1, 2024
kpango
force-pushed
the
bugfix/internal-grpc/ip-connection-idle-removal-problem
branch
from
7afc379 to
87bda2f
Compare
Update internal/net/grpc/pool/pool.go Signed-off-by: kpango <kpango@vdaas.org>
kpango
force-pushed
the
bugfix/internal-grpc/ip-connection-idle-removal-problem
branch
from
87bda2f to
4f2fd35
Compare
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/bugfix%2Finternal-grpc%2Fip-connection-idle-removal-problem/97c68eb9645d65a49ce0057f5a13adc1c6b710eb |
Profile Report
|
vankichi
approved these changes
Feb 2, 2024
vankichi
deleted the
bugfix/internal-grpc/ip-connection-idle-removal-problem
branch
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: