Fix to get only backoff metrics of discover RPC #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 31.60% 31.53% -0.08%
==========================================
Files 385 385
Lines 32691 32713 +22
==========================================
- Hits 10331 10315 -16
- Misses 21966 22001 +35
- Partials 394 397 +3
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
hlts2
changed the title
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/fix-discover-logic/701b3b4ba64b83c2fc5141b1a7d9fd05201e62c2 |
Profile Report
|
kpango
requested changes
Jun 23, 2022
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kpango
approved these changes
Jun 23, 2022
datelier
approved these changes
Jun 23, 2022
|
Thank you for your review! 🙏 |
kevindiu
pushed a commit
that referenced
this pull request
Jul 4, 2022
* fix context propagation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add method to get backoff instance Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix invalid memory access error and refactor disconnect logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add backoff name to roundrobin context Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update internal/client/v1/client/discoverer/discover.go Co-authored-by: Yusuke Kato <kpango@vdaas.org> * fix build error and reuse named return variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WHAT
I fixed code to get only backoff metrics of discover RPC.
WHY
There was a lot of backoff metrics in discover RPC before.
The current implementation included a backoff metrics that is not directly related to the RPC call.
https://github.com/vdaas/vald/blob/master/internal/client/v1/client/discoverer/discover.go#L221
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: