Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: Aggressive ruff pass (ruff v0.3.4) #23

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

tony
Copy link
Member

@tony tony commented Mar 24, 2024

ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .

Fixed 3 errors:

  • docs/conf.py: 1 × RET505 (superfluous-else-return)
  • src/g/__init__.py: 1 × RUF022 (unsorted-dunder-all)
  • tests/test_cli.py: 1 × PT006 (pytest-parametrize-names-wrong-type)

ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .

Fixed 3 errors:
- docs/conf.py:
    1 × RET505 (superfluous-else-return)
- src/g/__init__.py:
    1 × RUF022 (unsorted-dunder-all)
- tests/test_cli.py:
    1 × PT006 (pytest-parametrize-names-wrong-type)
@tony tony changed the title refactor!(ruff): Run all automated fixes as of ruff 0.3.4 Linting: Aggressive ruff pass (ruff v0.3.4) Mar 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.15%. Comparing base (77c30a8) to head (3be17e6).

Files Patch % Lines
docs/conf.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   72.15%   72.15%           
=======================================
  Files           5        5           
  Lines         158      158           
=======================================
  Hits          114      114           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony merged commit 5bbe6bf into master Mar 24, 2024
6 checks passed
@tony tony deleted the ruff-all-v0.3.4-pass branch March 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants