style: popover bgColor is too close to common

[mynetfan]

Description

修复dark主题下popover背景色与主体区域背景色太过接近的问题.
一些有问题的表现：
antd的Select下拉区域与周边区分不明显；naive的tooltip组件与背景难以区分

以上没有全部列举。

fix #5361

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Style
  • Updated dark theme color token for popovers to improve visual contrast and readability

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8eb30f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/base/design/src/design-tokens/dark.css

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The pull request modifies the dark theme CSS variables, specifically focusing on the --popover variable within the .dark class. The change involves updating the color definition from 222.82deg 8.43% 12.27% to 0 0 14.2%, addressing a previous issue where the popover background color was too similar to the theme area's background. The modification is accompanied by a commented-out version of the original value, suggesting a careful transition approach.

Changes

File	Change Summary
packages/@core/base/design/src/design-tokens/dark.css	Updated --popover CSS variable in .dark class from 222.82deg 8.43% 12.27% to 0 0 14.2%

Possibly related PRs

• fix: default theme colors cannot be overridden #4636: Modifications to theme color handling
• fix: login page brand color does not take effect #4655: Updates to theme color definitions
• fix: primaryColor calculation #5337: Calculation of primary theme colors

Suggested reviewers

• anncwb
• vince292007

Poem

🐰 In the realm of dark design tokens bright,
A popover's hue shifts with coding might
From degrees to zero, a subtle dance
Of color and contrast, a thematic chance
Rabbit's code whispers: "Clarity's delight!" 🎨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79d4d2f and 8eb30f9.

📒 Files selected for processing (1)

• packages/@core/base/design/src/design-tokens/dark.css (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Check (windows-latest)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Test (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: Test (ubuntu-latest)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: post-update (ubuntu-latest)

🔇 Additional comments (1)

packages/@core/base/design/src/design-tokens/dark.css (1)

18-22: Color change improves contrast with background

The modification from 222.82deg 8.43% 12.27% to 0 0 14.2% is a good solution:

• Removes the blue tint by setting hue and saturation to 0
• Increases lightness by ~2% for better visibility
• Creates clearer distinction from the background color (222.34deg 10.43% 12.27%)

Please verify this change improves visibility in the following components:

• Ant Design's Select dropdown
• Naive UI's tooltip
• Other popover-based components

Run this script to find potentially affected components:

✅ Verification successful

Color change is safely integrated with theme system

The --popover variable change is properly integrated into Tailwind's theming system and will consistently propagate to all components through the design tokens infrastructure. No conflicting implementations or hardcoded values were found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for components using popover styles
echo "Searching for components using popover styles..."
rg -l "(?i)(popover|tooltip|dropdown|select)" --type vue

# Search for CSS/SCSS files that might override popover styles
echo "Searching for style overrides..."
rg -l "(?i)(--popover|\.popover|\.tooltip|\.dropdown|\.select)" --type css --type scss

Length of output: 386

---

Script:

#!/bin/bash
# Find all potential UI files
echo "Finding UI files..."
fd -e vue -e jsx -e tsx -e css -e scss -e less

# Search for popover-related patterns in all files
echo -e "\nSearching for popover variable usage..."
rg "var\(--popover\)" -l

# Search for popover/tooltip classes and components
echo -e "\nSearching for popover/tooltip related patterns..."
rg "(?i)(\.popover|\.tooltip|class=\".*?popover|class=\".*?tooltip)" -l

Length of output: 31908

---

Script:

#!/bin/bash
# Check tailwind config implementation
echo "Checking tailwind config..."
rg --type ts "popover" internal/tailwind-config/src/index.ts -C 5

# Check component implementations
echo -e "\nChecking component implementations..."
rg "(?i)(--popover|\.popover|\.tooltip)" packages/@core/ui-kit/shadcn-ui/src/components/tooltip/tooltip.vue -C 5
rg "(?i)(--popover|\.popover|\.tooltip)" packages/@core/ui-kit/menu-ui/src/components/menu-item.vue -C 5
rg "(?i)(--popover|\.popover|\.tooltip)" packages/effects/common-ui/src/components/ellipsis-text/ellipsis-text.vue -C 5

Length of output: 1581

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.