Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select Long option style problem #5030

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

DesignHhuang
Copy link
Contributor

@DesignHhuang DesignHhuang commented Dec 5, 2024

Description

处理select 选择长选项导致样式超出的问题 close: #5029

处理前:
image

处理后:
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Style
    • Enhanced the visual presentation of form fields by updating the template structure and adding a new styling class.

These changes improve the user experience without altering existing functionality.

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 86eac78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Dec 5, 2024

Walkthrough

The changes in this pull request focus on the form-field.vue component, specifically modifying the template structure by adding the overflow-hidden class to a wrapping div element. This adjustment enhances the visual presentation of the component while maintaining the existing functionality and event handling logic. No alterations were made to the underlying properties or public entities, ensuring that the component's interaction with the form context remains consistent.

Changes

File Path Change Summary
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue Updated template to include overflow-hidden class on wrapping div, no changes to functionality.

Possibly related issues

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007

Poem

In a field where forms do play,
A class was added, brightening the way.
Overflow hidden, neat and tight,
Making our inputs a lovely sight!
With logic intact, the fields align,
A little change, and all's just fine! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/@core/ui-kit/form-ui/src/form-render/form-field.vue

Oops! Something went wrong! :(

ESLint: 9.16.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7ab0025 and 86eac78.

📒 Files selected for processing (1)
  • packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/@core/ui-kit/form-ui/src/form-render/form-field.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vince292007 vince292007 changed the title fix: 处理select 选择长选项导致样式超出的问题 fix: select Long option style problem Dec 5, 2024
@vince292007 vince292007 merged commit 05b4b61 into vbenjs:main Dec 5, 2024
16 checks passed
@vince292007 vince292007 added the bug Something isn't working label Dec 5, 2024
@gee1k
Copy link
Contributor

gee1k commented Dec 6, 2024

这个 PR 有问题,会导致Form的错误信息不显示。且内部输入框聚焦时的 box-shadow 会被overflow 属性裁剪。
@vince292007

@DesignHhuang
Copy link
Contributor Author

这个 PR 有问题,会导致Form的错误信息不显示。且内部输入框聚焦时的 box-shadow 会被overflow 属性裁剪。 @vince292007

嗯,这边样式有点问题,还需要再调整下方案

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 表单中select 组件,如果选项长度很长的话会有样式bug
3 participants