Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFMPEG 6 + Cmake deprecation updates #27

Open
wants to merge 4 commits into
base: linux
Choose a base branch
from

Conversation

bedwardly-down
Copy link
Contributor

I know there hasn't been that much activity in the main repository over the past few years, but I've gotten the code to build and run successfully on FreeBSD 14.0 with Clang17 using minimum changes. The only real major library deprecations were with FFMpeg, most of which should compile on FFMpeg 5 (not sure about 4) if anyone needs the older versions supported. I also removed FindGLEW.cmake since that now is one of the default modules in modern CMake releases.

@bedwardly-down
Copy link
Contributor Author

Accidentally forgot to update the top level CMakeLists.txt to use the proper GLEW variables.

@JanSimek
Copy link
Contributor

JanSimek commented Sep 5, 2024

I tried to compile this branch and it seems one more fix will need to be added for FFMPEG 7 compatibility:

shadowgrounds/storm/storm3dv2/treader.cpp:145:65: error: ‘struct AVCodecContext’ has no member named ‘channels’
  145 |                     builder->setStereo(mContext->audiocodecctx->channels);

I guess something like this: https://github.com/darlinghq/darling/pull/1537/files

It is a shame this engine was abandoned. I really enjoyed the game.

@bedwardly-down
Copy link
Contributor Author

I tried to compile this branch and it seems one more fix will need to be added for FFMPEG 7 compatibility:

shadowgrounds/storm/storm3dv2/treader.cpp:145:65: error: ‘struct AVCodecContext’ has no member named ‘channels’
  145 |                     builder->setStereo(mContext->audiocodecctx->channels);

I guess something like this: https://github.com/darlinghq/darling/pull/1537/files

It is a shame this engine was abandoned. I really enjoyed the game.

That compiles correctly on FFMPEG 6, so I'll add it. Thanks

@bedwardly-down
Copy link
Contributor Author

That should fix it. Might as well make FFMPEG 6 the baseline minimum required version now. I played the game quite a bit back in the day, too, although this source release has some major bugs (one of which being no assets load properly once you get past the main menu screen)

@vayerx
Copy link
Owner

vayerx commented Sep 7, 2024

@bedwardly-down,
Thanks for PR!
I found that I have some local commits from 2014 (omg). I'm trying to resolve conflicts and fix build. I'll do my best to merge your PR as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants