feat: add option to disable d3 transitions. #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of option to chart props: disableD3Transitions()
This pull request adds an extra option to the chart props called "disableD3Transitions" which disables the d3Transition function used in icicle.js. The reason that I think this is necessary is because, while developing my react application using this library, I encountered an issue where d3 transitions throws an error on very fast re-renders of the chart. A solution to this fix is to completely remove the d3 transition function and set the transition value to null. This causes the animation to be default (therefore transitionDuration does not work if disableD3Transition is true), but fixes the fast re-render issue.
Here is an example of the error generated by d3 transitions.