Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4382 - Allow limits of the total *number* of pieces a GKC can affect, and a property to find out how many it *did* affect #12245

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Cattlesquat
Copy link
Collaborator

@Cattlesquat Cattlesquat commented Apr 20, 2023

image

Always good to hit "the oldest bug in the buglist" :)

@Cattlesquat Cattlesquat added this to the 3.7.0 milestone Apr 20, 2023
@BrentEaston
Copy link
Collaborator

Options that would be useful:

  1. Stop GKC after {expression} number of matches found
  2. Stop GKC after {expression} number of pieces have been checked
  3. Perform GKC until {expression} is false
  4. Perform GKC while {expression} is true

If you are also adding properties that track the number of checks and number of matches, then those expressions could be combined in the while/until expression. e,g, perform GKC while expression is true or until you have applied it to 10 pieces.

In fact 1 & 2 are probably not needed, but it makes sense to include them as 'simple' options. 3 & 4 for more advanced users.

@Cattlesquat Cattlesquat changed the title 4382 - Allow limits of the total *number* of pieces a GKC can effect, and a property to find out how many it *did* affect 4382 - Allow limits of the total *number* of pieces a GKC can affect, and a property to find out how many it *did* affect Apr 21, 2023
@Cattlesquat Cattlesquat linked an issue Apr 24, 2023 that may be closed by this pull request
@Cattlesquat Cattlesquat added Ready for Review Ready to be reviewed for Merging and removed Work In Progress labels Apr 26, 2023
@Cattlesquat Cattlesquat added Work In Progress and removed Ready for Review Ready to be reviewed for Merging labels May 5, 2023
@uckelman uckelman modified the milestones: 3.7.0, 3.8.0 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report number of Units that matched a Global Key Command
3 participants