Sanitize xattr values in eos (cs3org#3438)

vascoguita · Nov 11, 2022 · 50d94ba · 50d94ba
1 parent 49c701c
commit 50d94ba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog/unreleased/sanitize-eos-xattr-values.md b/changelog/unreleased/sanitize-eos-xattr-values.md
@@ -0,0 +1,3 @@
+Enhancement: Sanitize non-utf8 characters in xattr values in EOS
+
+https://github.com/cs3org/reva/pull/3438
diff --git a/pkg/eosclient/eosbinary/eosbinary.go b/pkg/eosclient/eosbinary/eosbinary.go
@@ -1074,7 +1074,7 @@ func (c *Client) parseFileInfo(ctx context.Context, raw string, parseFavoriteKey
 					previousXAttr = strings.Replace(previousXAttr, "user.", "", 1)
 				}
 			case partsByEqual[0] == "xattrv":
-				attrs[previousXAttr] = partsByEqual[1]
+				attrs[previousXAttr] = strings.ToValidUTF8(partsByEqual[1], "")
 				previousXAttr = ""
 			default:
 				kv[partsByEqual[0]] = partsByEqual[1]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Enhancement: Sanitize non-utf8 characters in xattr values in EOS

		https://github.com/cs3org/reva/pull/3438