Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Rewrite core #42

Open
vars1ty opened this issue Apr 18, 2023 · 2 comments
Open

[Refactor] Rewrite core #42

vars1ty opened this issue Apr 18, 2023 · 2 comments
Assignees
Labels
« ??? » New Feature/Improvement New feature/improvement which may prove to be difficult than others

Comments

@vars1ty
Copy link
Owner

vars1ty commented Apr 18, 2023

Such as using structures more and having variables in them, try and reduce the amount of variables created via lazy_static, etc.

@vars1ty vars1ty added the « ??? » New Feature/Improvement New feature/improvement which may prove to be difficult than others label Apr 18, 2023
@vars1ty vars1ty self-assigned this Apr 18, 2023
@vars1ty vars1ty changed the title [Refactor] Rework tons of things [Refactor] Rewrite core May 31, 2023
@vars1ty
Copy link
Owner Author

vars1ty commented May 31, 2023

Title updated to reflect on the issue better, will be done when I got time for it.
Will also happen in parallel with #38, one example of a much-needed rewrite is Config.
Old "structure":
image

New:
image

List:

  • Rewrite Config base
  • Sync Config changes across the project
  • Look into rewriting how the Cava implementation works
  • Refactor other core parts, such as ui

vars1ty pushed a commit that referenced this issue Jun 21, 2023
@vars1ty
Copy link
Owner Author

vars1ty commented Jun 21, 2023

Commit c38c84f removed is_feature_active, which will be needed again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
« ??? » New Feature/Improvement New feature/improvement which may prove to be difficult than others
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant