Rework !important hack to avoid flicker
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the following was happening when an export Kobweb page was visited which used a conditional breakpoint style: 1. The browser loaded the export HTML, which correctly included the `!important` styling 2. When the JS was loaded, the styles were overridden by Silk initialization, which did not use `!important` 3. On the next event loop, the Silk hack overwrote the styles to include `!important` This meant that any styling that depended on the `!important` was broken between steps 2 and 3. This would manifest as a layout flicker. The new approach bypasses Compose HTML styling altogether and instead registers these breakpoint styles directly to a stylesheet, effectively bypassing step 2.
bitspittle
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the following was happening when an export Kobweb page was visited which used a conditional breakpoint style:
!importantstyling!important!importantThis meant that any styling that depended on the
!importantwas broken between steps 2 and 3. This would manifest as a layout flicker.The new approach bypasses Compose HTML styling altogether and instead registers these breakpoint styles directly to a stylesheet, effectively bypassing step 2.