Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new API for build script #394

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Use new API for build script #394

merged 1 commit into from
Jun 8, 2022

Conversation

roya1v
Copy link
Contributor

@roya1v roya1v commented Jun 5, 2022

Changed the build script to use the new Task API as described in issue #392

@0xTim
Copy link
Member

0xTim commented Jun 6, 2022

@jroya1 can you test the script first? It doesn't currently compile

scripts/build.swift:48:24: error: cannot assign value of type 'String' to type 'URL?'
    task.executableURL = "/usr/bin/env"
                       ^
scripts/build.swift:61:24: error: cannot assign value of type 'String' to type 'URL?'
    task.executableURL = "/usr/bin/env"
                       ^

@roya1v
Copy link
Contributor Author

roya1v commented Jun 6, 2022

@0xTim Sorry, silly me being too confident :) Should be working now.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit b994beb into vapor:main Jun 8, 2022
@ahmdyasser ahmdyasser linked an issue Jun 9, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build script uses deprecated APIs
2 participants