This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Blazing fast HTML escaping. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also yields a ~13% improvement in the old
|
|
The remaining CI failure is unrelated to this PR, but we may want to only run these benchmarks in Release mode (they take much longer in Debug mode). |
|
Friendly ping @tanner0101 :-) |
tanner0101
approved these changes
Jun 8, 2019
There was a problem hiding this comment.
Thanks, @MrMage !
I've opened an issue here to port these changes to LeafKit for Vapor 4: vapor/leaf-kit#17
|
Hey @MrMage, you just merged a pull request, have a coin! You now have 29 coins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resulting in 10x-100x (seriously) speedups across the board. And the common case where no replacements are needed actually benefits the most!