Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sendable warnings #533

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

fabianfett
Copy link
Collaborator

As NIO becomes more and more Sendable clean, new issues arise in libraries using NIO. This pr fixes some new ones.

@fabianfett fabianfett requested a review from gwynne as a code owner January 27, 2025 12:38
@fabianfett fabianfett force-pushed the ff-fix-Sendable-warnings branch from 68c28b2 to ab0695f Compare January 27, 2025 12:39
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.75%. Comparing base (7c29718) to head (ab0695f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...urces/ConnectionPoolModule/NIOLockedValueBox.swift 10.00% 9 Missing ⚠️
Sources/ConnectionPoolModule/NIOLock.swift 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   61.78%   61.75%   -0.04%     
==========================================
  Files         125      125              
  Lines       10074    10089      +15     
==========================================
+ Hits         6224     6230       +6     
- Misses       3850     3859       +9     
Files with missing lines Coverage Δ
Sources/PostgresNIO/New/PSQLTask.swift 77.77% <ø> (ø)
Sources/PostgresNIO/PostgresDatabase+Query.swift 32.14% <ø> (ø)
Sources/ConnectionPoolModule/NIOLock.swift 74.46% <88.00%> (+1.74%) ⬆️
...urces/ConnectionPoolModule/NIOLockedValueBox.swift 30.76% <10.00%> (-69.24%) ⬇️

@fabianfett fabianfett merged commit d6b6487 into vapor:main Jan 27, 2025
9 checks passed
@fabianfett fabianfett deleted the ff-fix-Sendable-warnings branch January 27, 2025 17:30
@fabianfett fabianfett added the semver-minor Adds new public API. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants