Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an availability issue for DiscardingTaskGroup on watchOS #448

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

lovetodream
Copy link
Contributor

DiscardingTaskGroup is only available on watchOS >=10.0 :).

This patch allows the ConnectionPoolModule to be successfully built for watchOS.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e60e495) 59.81% compared to head (03bfb62) 59.84%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   59.81%   59.84%   +0.02%     
==========================================
  Files         124      124              
  Lines        9915     9937      +22     
==========================================
+ Hits         5931     5947      +16     
- Misses       3984     3990       +6     
Files Coverage Δ
Sources/ConnectionPoolModule/ConnectionPool.swift 94.42% <ø> (ø)
.../Connection/PostgresConnection+Configuration.swift 50.00% <100.00%> (+0.70%) ⬆️
...urces/PostgresNIO/New/PostgresChannelHandler.swift 84.77% <100.00%> (ø)
...stgresNIO/New/PostgresFrontendMessageEncoder.swift 100.00% <100.00%> (ø)
...nection State Machine/ConnectionStateMachine.swift 62.87% <86.66%> (+0.41%) ⬆️

... and 2 files with indirect coverage changes

@fabianfett fabianfett added the semver-patch No public API change. label Jan 9, 2024
@fabianfett fabianfett merged commit ea0800d into vapor:main Jan 9, 2024
@lovetodream lovetodream deleted the fix-watchos-build branch January 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants