Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PoolStateMachine #427

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Add PoolStateMachine #427

merged 3 commits into from
Oct 25, 2023

Conversation

fabianfett
Copy link
Collaborator

No description provided.

@fabianfett fabianfett added the semver-patch No public API change. label Oct 25, 2023
@fabianfett fabianfett requested a review from gwynne October 25, 2023 20:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #427 (2ad5245) into main (17d3c80) will increase coverage by 0.97%.
The diff coverage is 70.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   58.03%   59.01%   +0.97%     
==========================================
  Files         120      120              
  Lines        8843     9188     +345     
==========================================
+ Hits         5132     5422     +290     
- Misses       3711     3766      +55
Files Coverage Δ
...tionPoolModule/PoolStateMachine+RequestQueue.swift 100.00% <100.00%> (ø)
...nPoolModule/PoolStateMachine+ConnectionGroup.swift 86.15% <88.88%> (+3.78%) ⬆️
...ources/ConnectionPoolModule/TinyFastSequence.swift 92.68% <87.23%> (ø)
...ources/ConnectionPoolModule/PoolStateMachine.swift 67.42% <66.10%> (+50.76%) ⬆️

... and 1 file with indirect coverage changes

gwynne
gwynne approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few very minor nits

@fabianfett fabianfett force-pushed the ff-pool-StateMachine branch from 5c12d49 to ecffeca Compare October 25, 2023 20:17
@fabianfett @gwynne
Apply suggestions from code review
2ad5245 
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
@fabianfett fabianfett merged commit 472ff4a into vapor:main Oct 25, 2023
@fabianfett fabianfett deleted the ff-pool-StateMachine branch October 25, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
semver-patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @codecov-commenter @gwynne