-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PoolStateMachine.ConnectionGroup
(#425)
#426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
reviewed
Oct 20, 2023
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
Sources/ConnectionPoolModule/PoolStateMachine+ConnectionGroup.swift
Outdated
Show resolved
Hide resolved
gwynne
approved these changes
Oct 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 56.99% 58.03% +1.04%
==========================================
Files 119 120 +1
Lines 8410 8843 +433
==========================================
+ Hits 4793 5132 +339
- Misses 3617 3711 +94
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ConnectionPool
Features and bugs that are related to the impl in ConnectionPoolModule
semver-patch
No public API change.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.