Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use README header image compatible with light/dark mode #393

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 10, 2023

Also centers the logo and badges, adds proper links to the badges, and fixes use of non-https image URLs.

@gwynne gwynne requested review from fabianfett and 0xTim August 10, 2023 10:37
Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

gwynne and others added 2 commits August 10, 2023 05:44
Co-authored-by: Fabian Fett <fabianfett@apple.com>
Co-authored-by: Fabian Fett <fabianfett@apple.com>
@codecov-commenter
Copy link

Codecov Report

Merging #393 (bdae94f) into main (52d5636) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files         109      109           
  Lines        8764     8764           
=======================================
  Hits         4166     4166           
  Misses       4598     4598           

Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@fabianfett fabianfett merged commit 5217ba7 into main Aug 10, 2023
@fabianfett fabianfett deleted the readme-color-scheme branch August 10, 2023 11:16
@fabianfett fabianfett added the semver-noop No version bump required. label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-noop No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants