close() closes immediately; Add new closeGracefully()
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
changed the title
close() closes immediately; Add new gracefulClose()close() closes immediately; Add new gracefulClose()
fabianfett
changed the title
close() closes immediately; Add new gracefulClose()close() closes immediately; Add new closeGracefully()
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 46.07% 47.53% +1.46%
==========================================
Files 109 109
Lines 8728 8764 +36
==========================================
+ Hits 4021 4166 +145
+ Misses 4707 4598 -109
|
fabianfett
commented
Aug 9, 2023
Comment on lines
+57
to
+60
| @available(*, deprecated, renamed: "clientClosesConnection") | ||
| public static let connectionQuiescing = Self.clientClosesConnection | ||
|
|
||
| @available(*, deprecated, message: "Use the more specific `serverClosedConnection` or `clientClosedConnection` instead") |
gwynne
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370.
This PR changes the behavior of
close().close()now closes a connection immediately. We introduce acloseGracefully()that now has the same behavior as close before. Since we never documented the old close behavior and it is unfortunate that close does depend on the remote server to fulfill all queries, we consider it okay to change the behavior in this way. The current behavior is harmful since there is currently no way to force close a connection. Users might be in a position to force close a connection if a server stops responding.Alternative: close keeps graceful close behavior and we add a closeForcefully method instead