Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple warnings generated by the documentation build #378

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fix multiple warnings generated by the documentation build #378

merged 2 commits into from
Jul 29, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jul 29, 2023 •
edited by MahdiBM
Loading

Some simple cleanup.

@gwynne gwynne requested a review from fabianfett July 29, 2023 08:42
fabianfett
fabianfett approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023 •
edited
Loading

Codecov Report

Merging #378 (bf500cd) into main (fcb2e66) will increase coverage by 1.37%.
Report is 4 commits behind head on main.
The diff coverage is 67.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   42.98%   44.35%   +1.37%     
==========================================
  Files         118      118              
  Lines        8243     8630     +387     
==========================================
+ Hits         3543     3828     +285     
- Misses       4700     4802     +102
Files Changed Coverage Δ
Sources/PostgresNIO/Data/PostgresDataType.swift 56.19% <54.91%> (-4.19%) ⬇️
Sources/PostgresNIO/New/PostgresQuery.swift 78.51% <84.05%> (+4.54%) ⬆️
Sources/PostgresNIO/New/PSQLError.swift 75.27% <88.37%> (+20.48%) ⬆️
.../Connection/PostgresConnection+Configuration.swift 46.47% <100.00%> (+0.76%) ⬆️

@gwynne gwynne force-pushed the fix-documentation-warnings branch from 430b0eb to bf500cd Compare July 29, 2023 08:52
@gwynne gwynne merged commit f3587a5 into main Jul 29, 2023
@gwynne gwynne deleted the fix-documentation-warnings branch July 29, 2023 09:01
@fabianfett fabianfett added the semver-noop No version bump required. label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
semver-noop No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwynne @codecov-commenter @fabianfett