Use computed property to PostgresConnection.Configuration.TLS.disable for concurrency safe

[sidepelican]

PostgresConnection.Configuration.TLS.disable is declared as var but it causes compiler warning on strict concurrency checking.

This value seems to not to be modified in runtime.
So this should be changed to let.

[MahdiBM]

This is a breaking change but it does seem to me that the property was supposed to be a computed property not stored.

I personally don't mind letting it slide although it's a breaking change, because it isn't supposed to be used like that anyway.

[MahdiBM]

@gwynne beat me to it while i was typing on phone 😅

My review contained inaccurate commentary.

[gwynne]

It is technically a breaking change, but in this case the likelihood of someone having an actual source-compatibility issue is very low, and would have required doing something that was fairly obviously unintended.

[gwynne]

Thanks for the fix!

[fabianfett]

@sidepelican Thanks for uncovering this! Really appreciated!

I'm aware that this is technically a breaking change. However, if someone actually used the set on this property, they are likely in much more trouble. For this reason, I'm fine with breaking API in a non major release.