Update PostgresRowSequence.swift #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in issue #279 by fabianfett titled "Make PostgresRowSequence.collect public"
Closed
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 44.42% 44.42%
=======================================
Files 115 115
Lines 9675 9675
=======================================
Hits 4298 4298
Misses 5377 5377
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fabianfett
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Great. Thanks for tackling this. Since this is a public API change let’s also ask @gwynne for an opinion.
gwynne
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #279 by @fabianfett
As requested in recent issue attached above, the function should be made public. That is the only change made in this pull request and should solve the issue!