Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contains(_:) to PostgresRandomAccessRow #270

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

fabianfett
Copy link
Collaborator

Motivation

Users need a way to check whether a column exists in PostgresRandomAccessRow.

Changes

  • Add contains(_:) to PostgresRandomAccessRow

@fabianfett fabianfett requested a review from gwynne March 18, 2022 12:40
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@gwynne gwynne added the enhancement New feature or request label Mar 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #270 (5d0662e) into main (e9e431c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   44.43%   44.42%   -0.02%     
==========================================
  Files         115      115              
  Lines        9672     9675       +3     
==========================================
  Hits         4298     4298              
- Misses       5374     5377       +3     
Flag Coverage Δ
unittests 44.42% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/Data/PostgresRow.swift 49.24% <0.00%> (-0.76%) ⬇️

@gwynne gwynne merged commit def4fe8 into vapor:main Mar 18, 2022
@VaporBot
Copy link

These changes are now available in 1.9.0

@fabianfett fabianfett deleted the ff-add-has-column branch April 24, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants