Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PostgresChannelHandler #251

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

fabianfett
Copy link
Collaborator

Same old story: Drop PSQL prefix, use Postgres prefix.

@fabianfett fabianfett requested a review from gwynne March 9, 2022 09:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #251 (e9912c1) into main (1cd8d36) will increase coverage by 4.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   39.78%   43.82%   +4.03%     
==========================================
  Files         115      115              
  Lines        9513     9520       +7     
==========================================
+ Hits         3785     4172     +387     
+ Misses       5728     5348     -380     
Flag Coverage Δ
unittests 43.82% <0.00%> (+4.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift 17.48% <0.00%> (+0.93%) ⬆️
Sources/PostgresNIO/New/PSQLEventsHandler.swift 0.00% <ø> (ø)
...urces/PostgresNIO/New/PostgresChannelHandler.swift 61.83% <ø> (ø)
...ces/PostgresNIO/New/PostgresRow-multi-decode.swift 4.44% <0.00%> (+0.19%) ⬆️
Sources/PostgresNIO/Data/PostgresRow.swift 50.00% <0.00%> (+1.02%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 93.25% <0.00%> (+2.24%) ⬆️
...ostgresNIO/Deprecated/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...ostgresNIO/New/PostgresBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
... and 23 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barely know why approval should be required on this kind of thing 😁

@fabianfett fabianfett force-pushed the ff-rename-PSQLChannelHandler branch from 9a98b7e to f94cc9f Compare March 11, 2022 08:43
@fabianfett fabianfett merged commit 7f290f2 into vapor:main Mar 11, 2022
@fabianfett fabianfett deleted the ff-rename-PSQLChannelHandler branch March 11, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants