-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DataRow Sendable #250
Conversation
Codecov Report
@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 39.78% 43.75% +3.96%
==========================================
Files 115 115
Lines 9513 9512 -1
==========================================
+ Hits 3785 4162 +377
+ Misses 5728 5350 -378
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -116,3 +120,7 @@ extension DataRow { | |||
return self[byteIndex] | |||
} | |||
} | |||
|
|||
#if swift(>=5.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 5.6 rather than 5.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marching onward!
efd07c2
to
9c238c2
Compare
Motivation
For Swift 5.6, we want to support Sendable checks.
DataRow
generates a lot of warnings in CI today.Changes
DataRow
Sendable