Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Postgres async query public #249

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

fabianfett
Copy link
Collaborator

Follow up to #248. Last step in making the new Query API public.

@fabianfett fabianfett requested a review from gwynne March 8, 2022 22:57
@fabianfett fabianfett force-pushed the ff-make-PostgresQuery-public branch from 4d250af to 415336a Compare March 8, 2022 23:00
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉!!!

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #249 (ab77d02) into main (3d6666d) will increase coverage by 4.03%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   39.74%   43.77%   +4.03%     
==========================================
  Files         115      115              
  Lines        9499     9506       +7     
==========================================
+ Hits         3775     4161     +386     
+ Misses       5724     5345     -379     
Flag Coverage Δ
unittests 43.77% <93.75%> (+4.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift 15.42% <0.00%> (+0.72%) ⬆️
Sources/PostgresNIO/New/PostgresQuery.swift 86.66% <100.00%> (ø)
...ces/PostgresNIO/New/PostgresRow-multi-decode.swift 4.44% <0.00%> (+0.19%) ⬆️
Sources/PostgresNIO/Data/PostgresRow.swift 50.00% <0.00%> (+1.02%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 93.25% <0.00%> (+2.24%) ⬆️
...ostgresNIO/Deprecated/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...es/PostgresNIO/New/PSQLBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
...urces/PostgresNIO/New/Messages/ErrorResponse.swift 32.30% <0.00%> (+3.07%) ⬆️
... and 22 more

@fabianfett fabianfett merged commit d9ba577 into vapor:main Mar 11, 2022
@fabianfett fabianfett deleted the ff-make-PostgresQuery-public branch March 11, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants