Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PostgresEncodingContext & PostgresDecodingContext public #243

Merged

Conversation

fabianfett
Copy link
Collaborator

Motivation

We want to open up our new API

Changes

  • Make PostgresEncodingContext public
  • Make PostgresDecodingContext public

Result

Smaller future open up PRs.

@fabianfett fabianfett requested a review from gwynne March 4, 2022 08:53
@fabianfett fabianfett force-pushed the ff-make-PostgresCodingContexts-public branch from 4ed26fa to 0470672 Compare March 4, 2022 08:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #243 (06002b0) into main (ef425af) will increase coverage by 4.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   39.57%   43.61%   +4.03%     
==========================================
  Files         115      115              
  Lines        9479     9486       +7     
==========================================
+ Hits         3751     4137     +386     
+ Misses       5728     5349     -379     
Flag Coverage Δ
unittests 43.61% <100.00%> (+4.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/PostgresNIO/New/PostgresCodable.swift 91.66% <100.00%> (ø)
...ces/PostgresNIO/New/PostgresRow-multi-decode.swift 4.44% <0.00%> (+0.19%) ⬆️
...es/PostgresNIO/Connection/PostgresConnection.swift 11.83% <0.00%> (+0.75%) ⬆️
Sources/PostgresNIO/Data/PostgresRow.swift 50.00% <0.00%> (+1.02%) ⬆️
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 94.73% <0.00%> (+1.05%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
...ostgresNIO/Deprecated/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...es/PostgresNIO/New/PSQLBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
...urces/PostgresNIO/New/Messages/ErrorResponse.swift 32.30% <0.00%> (+3.07%) ⬆️
Sources/PostgresNIO/New/PostgresCell.swift 96.77% <0.00%> (+3.22%) ⬆️
... and 21 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabianfett fabianfett merged commit 495dec9 into vapor:main Mar 5, 2022
@fabianfett fabianfett deleted the ff-make-PostgresCodingContexts-public branch March 5, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants