Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PSQLConnection into PostgresConnection #240

Conversation

fabianfett
Copy link
Collaborator

Motivation

We want to evolve our current public API instead of just replacing it.

Changes

  • Merge PSQLConnection into PostgresConnection

Result

A cleaner public API

@fabianfett fabianfett requested a review from gwynne March 2, 2022 10:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #240 (398ea3b) into main (43742ef) will increase coverage by 3.61%.
The diff coverage is 22.90%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   39.99%   43.60%   +3.61%     
==========================================
  Files         116      115       -1     
  Lines        9467     9485      +18     
==========================================
+ Hits         3786     4136     +350     
+ Misses       5681     5349     -332     
Flag Coverage Δ
unittests 43.60% <22.90%> (+3.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <ø> (+1.42%) ⬆️
Sources/PostgresNIO/New/PSQLEventsHandler.swift 0.00% <0.00%> (-26.09%) ⬇️
...es/PostgresNIO/Connection/PostgresConnection.swift 11.83% <20.00%> (+11.83%) ⬆️
...nection State Machine/ConnectionStateMachine.swift 54.66% <48.27%> (+8.22%) ⬆️
Sources/PostgresNIO/New/PSQLChannelHandler.swift 61.83% <100.00%> (+10.66%) ⬆️
...ces/PostgresNIO/New/PostgresRow-multi-decode.swift 4.44% <0.00%> (+0.19%) ⬆️
Sources/PostgresNIO/Data/PostgresRow.swift 50.00% <0.00%> (+1.02%) ⬆️
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 94.68% <0.00%> (+1.06%) ⬆️
... and 26 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

@fabianfett fabianfett merged commit d16467d into vapor:main Mar 2, 2022
@fabianfett fabianfett deleted the ff-merge-PSQLConnection-into-PostgresConnection branch March 2, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants