Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all PostgresConnection code into one file #228

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

fabianfett
Copy link
Collaborator

Motivation

When we merge PostgresConnection and PSQLConnection, I would love to see all changes in one file.

Changes

  • Move all PostgresConnection code into one file

Result

  • One file for PostgresConnection

@fabianfett fabianfett requested a review from gwynne February 23, 2022 08:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #228 (13babe4) into main (7f53867) will increase coverage by 4.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   39.10%   43.19%   +4.08%     
==========================================
  Files         121      117       -4     
  Lines        9315     9322       +7     
==========================================
+ Hits         3643     4027     +384     
+ Misses       5672     5295     -377     
Flag Coverage Δ
unittests 43.19% <0.00%> (+4.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/PostgresNIO/Connection/PostgresConnection.swift 0.00% <0.00%> (ø)
...s/PostgresNIO/New/Data/Array+PostgresCodable.swift 94.68% <0.00%> (+1.06%) ⬆️
...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift 19.60% <0.00%> (+1.42%) ⬆️
Sources/PostgresNIO/New/PSQLConnection.swift 30.00% <0.00%> (+2.10%) ⬆️
...s/PostgresNIO/Message/PostgresMessageDecoder.swift 95.45% <0.00%> (+2.27%) ⬆️
...es/PostgresNIO/New/PSQLBackendMessageDecoder.swift 93.28% <0.00%> (+2.98%) ⬆️
...urces/PostgresNIO/New/Messages/ErrorResponse.swift 32.30% <0.00%> (+3.07%) ⬆️
Sources/PostgresNIO/New/PostgresCell.swift 96.77% <0.00%> (+3.22%) ⬆️
...s/PostgresNIO/New/Data/Float+PostgresCodable.swift 76.66% <0.00%> (+3.33%) ⬆️
Sources/PostgresNIO/New/PSQLBackendMessage.swift 96.63% <0.00%> (+3.36%) ⬆️
... and 21 more

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabianfett fabianfett merged commit 041842b into vapor:main Feb 25, 2022
@fabianfett fabianfett deleted the ff-postgres-connection-one-file branch February 25, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants