Add PostgresQuery #223
Merged
Add PostgresQuery #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
commented
Feb 19, 2022
| @@ -26,7 +26,7 @@ public typealias PostgresFormatCode = PostgresFormat | |||
|
|
|||
| /// The data type's raw object ID. | |||
| /// Use `select * from pg_type where oid = <idhere>;` to lookup more information. | |||
| public struct PostgresDataType: RawRepresentable, Equatable, CustomStringConvertible { | |||
| public struct PostgresDataType: RawRepresentable, Hashable, CustomStringConvertible { | |||
There was a problem hiding this comment.
@gwynne We extend public API here!
fabianfett
force-pushed
the
ff-add-PostgresQuery
branch
from
3b66f7b to
3af6209
Compare
Codecov Report
@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 38.62% 43.19% +4.57%
==========================================
Files 120 121 +1
Lines 9271 9322 +51
==========================================
+ Hits 3581 4027 +446
+ Misses 5690 5295 -395
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Postgres compiles Fix tests
fabianfett
force-pushed
the
ff-add-PostgresQuery
branch
from
3af6209 to
4a2b050
Compare
gwynne
approved these changes
Feb 21, 2022
| @@ -26,7 +26,7 @@ public typealias PostgresFormatCode = PostgresFormat | |||
|
|
|||
| /// The data type's raw object ID. | |||
| /// Use `select * from pg_type where oid = <idhere>;` to lookup more information. | |||
| public struct PostgresDataType: RawRepresentable, Equatable, CustomStringConvertible { | |||
| public struct PostgresDataType: RawRepresentable, Hashable, CustomStringConvertible { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we encode bindings right before we send them out, in
PSQLFrontendMessageEncoder. This means that a JSONEncoder must be set per connection. This is not an ideal design. Further we need to wrap the values that we want to bind in an existential[PSQLEncodable].I propose changing this API and introducing an explicit
PostgresQuerytype, that isExpressibleByStringInterpolation.Changes
PostgresQueryPostgresBindingsPostgresJSONEncoderfromPSQLFrontendMessageEncoderResult