Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BufferedMessageEncoder, fix PSQLFrontendMessageEncoder #179

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

fabianfett
Copy link
Collaborator

Motivation

  • We want to communicate as efficiently as possible to the server. For this reason we use message pipelining within a query.
  • If we drop the current use of MessageToByteHandler and do the encoding in the PSQLChannelHandler, we can write to a single ByteBuffer and only forward this together with a flush

Changes

  • Add BufferedMessageEncoder
  • Rename PSQLFrontendMessage.Encoder to PSQLFrontendMessageEncoder (got its own file)

@fabianfett fabianfett added enhancement New feature or request part of a series labels Sep 18, 2021
@fabianfett fabianfett requested a review from gwynne September 18, 2021 14:50
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianfett fabianfett merged commit 8c32013 into vapor:main Sep 19, 2021
@fabianfett fabianfett deleted the ff-add-PSQLFrontendMessageEncoder branch September 19, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants