Add PSQLBackendMessageEncoder #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
reviewed
Sep 18, 2021
| func encode(data message: PSQLBackendMessage, out buffer: inout ByteBuffer) throws { | ||
| switch message { | ||
| case .authentication(let authentication): | ||
| buffer.writeBackendMessageID(message.id) |
There was a problem hiding this comment.
There is nothing specifically wrong with having it this way, but it nags at me to have the same line repeated in (almost) every single case like this over and over. Is there any not-horrible way to factor it out? (I can't think of something off the top of my head, and it's certainly not worth spending any amount of time on.)
There was a problem hiding this comment.
Transformed into one liners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To test a
PSQLChannelHandler, that uses an internalNIOSingleStepByteToMessageDecoder, in anEmbeddedChannelwe need to writeInbound bytes. To make this easier, this PR introduces aPSQLBackendMessageEncoderas a test utilChanges
PSQLBackendMessageEncoderPSQLBackendMessageEncoderin authentication testsNote
This pr only changes test code