Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless Equatable constraint #106

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Remove useless Equatable constraint #106

merged 3 commits into from
Jan 16, 2025

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Jan 16, 2025

We can get rid of the Equatable requirement in the multiparty body type typealias since it was really just used in tests

@ptoffy ptoffy requested review from 0xTim and gwynne as code owners January 16, 2025 08:55
@@ -31,7 +31,7 @@ final class AsyncSyncSequence<Base: Sequence>: AsyncSequence {
}

func makeAsyncIterator() -> Iterator {
defer { self.base = nil } // release the reference so no CoW is triggered
defer { self.base = nil } // release the reference so no CoW is triggered
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
defer { self.base = nil } // release the reference so no CoW is triggered
defer { self.base = nil } // release the reference so no CoW is triggered

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is swift-format's doing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... That's bizarre, wrong, stupid, pointless, and so forth. Oh well.

@gwynne gwynne added the semver-patch Internal changes only label Jan 16, 2025
@ptoffy ptoffy removed the semver-patch Internal changes only label Jan 16, 2025
Copy link

Benchmark Report

✅ Pull request has no significant performance differences ✅

Click to expand comparison result

Benchmark check running at 2025-01-16 11:37:12 UTC

The baseline 106/merge is EQUAL to the defined thresholds.

Click to expand benchmark result

Baseline 106/merge

Host a7f46776b36b with 2 aarch64 processors with 3 GB memory, running:
#23-Ubuntu SMP Mon Dec  9 23:51:16 UTC 2024

Parser

CollatingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

CollatingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 8 8 8 8 8 8 8 1

CollatingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 540 560 560 570 570 590 590 20

StreamingParserAllocations_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) (K) * 82 82 82 82 82 82 82 1

StreamingParserAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 6 6 6 6 6 6 6 1

StreamingParserCPUTime_256MiB

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 520 520 530 530 530 530 530 20

Serializer

100xSerializerCPUTime_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Time (user CPU) (ms) * 220 220 220 220 220 230 230 20

SerializerAllocations_1024Parts

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 3087 3087 3087 3087 3087 3087 3087 1

SerializerAllocations_Empty

Metric p0 p25 p50 p75 p90 p99 p100 Samples
Malloc (total) * 4 4 4 4 4 4 4 1

@ptoffy ptoffy merged commit 48c1058 into main Jan 16, 2025
11 of 12 checks passed
@ptoffy ptoffy deleted the remove-equatable branch January 16, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants