-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless Equatable
constraint
#106
Conversation
@@ -31,7 +31,7 @@ final class AsyncSyncSequence<Base: Sequence>: AsyncSequence { | |||
} | |||
|
|||
func makeAsyncIterator() -> Iterator { | |||
defer { self.base = nil } // release the reference so no CoW is triggered | |||
defer { self.base = nil } // release the reference so no CoW is triggered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defer { self.base = nil } // release the reference so no CoW is triggered | |
defer { self.base = nil } // release the reference so no CoW is triggered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is swift-format's doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... That's bizarre, wrong, stupid, pointless, and so forth. Oh well.
Benchmark Report✅ Pull request has no significant performance differences ✅ Click to expand comparison resultBenchmark check running at 2025-01-16 11:37:12 UTCThe baseline 106/merge is EQUAL to the defined thresholds. Click to expand benchmark resultBaseline 106/merge
ParserCollatingParserAllocations_256MiB
CollatingParserAllocations_Empty
CollatingParserCPUTime_256MiB
StreamingParserAllocations_256MiB
StreamingParserAllocations_Empty
StreamingParserCPUTime_256MiB
Serializer100xSerializerCPUTime_1024Parts
SerializerAllocations_1024Parts
SerializerAllocations_Empty
|
We can get rid of the
Equatable
requirement in the multiparty body type typealias since it was really just used in tests